Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Imports for Bluetooth Layer and Remove Wildcard Import #403

Closed
xee5ch opened this issue Dec 19, 2016 · 4 comments
Closed

Clean Imports for Bluetooth Layer and Remove Wildcard Import #403

xee5ch opened this issue Dec 19, 2016 · 4 comments
Assignees

Comments

@xee5ch
Copy link

xee5ch commented Dec 19, 2016

As requested in #399, I will try to clean up the imports for the bluetooth layer as requested by developers in TODO comments and confirmed by @gpotter2 and @p-l-. This is not recommended by [Python's official module import documentation recommendations](Set only required imports in bluetooth.py and remove this).

@xee5ch xee5ch changed the title Clean Imports for bluetooth Layer and Remove Wildcard Import Clean Imports for Bluetooth Layer and Remove Wildcard Import Dec 19, 2016
@p-l-
Copy link
Member

p-l- commented Dec 19, 2016

I'm not adding the tag help wanted, since you are going to work on that, unless you want me to add it. Don't hesitate if you need help.

@xee5ch
Copy link
Author

xee5ch commented Dec 19, 2016

I am sure I will mess it up, just removing the from scapy.all import * and see what breaks as I test it piece by piece.

@gpotter2
Copy link
Member

That's useally a good way to start 😄

@gpotter2
Copy link
Member

May now be closed

@guedou guedou closed this as completed Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants