Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The symbol ( & ) in note names is replaced by ( &amp ) which breaks the graph links #47

Closed
SmartSceptic opened this issue Dec 29, 2022 · 5 comments

Comments

@SmartSceptic
Copy link

SmartSceptic commented Dec 29, 2022

Describe the bug

I use special characters in the name of notes in my knowledge base to determine the type of note.
At least, symbol ( & ) in note names is replaced by ( &amp ) on graph panel, with breaks the graph links, an lead to unexistent note.
When you go to such a note from the left panel, the graph is not updated, and when you go from the graph to such a note, a blank page opens.

Probably other special characters allowed in Windows for use in file names also lead to a similar error.

To Reproduce

  • Create note, with name beginning wit "&"
  • Try open note from graf view
  • Try open note from left tree panel

Expected behavior
The symbol ( & ) and other windows allowed symbols in note names is not changed in view.

Screenshots
My test few notes in graf (multiple node connections also look weird)
image

image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Google Chrom
  • Version Latest perlite 1.5.1
@SmartSceptic SmartSceptic added the bug report Something isn't working label Dec 29, 2022
@secure-77
Copy link
Owner

I can reproduce this, seems that the html encoding should be replaced to url encoding for the links

@secure-77 secure-77 added confirmed bug and removed bug report Something isn't working labels Jan 22, 2023
@secure-77
Copy link
Owner

Well this will be fixed in release 1.5.2, but only for the ampersand, it seems that the json parser from php will decode some chars which then I need to replace back with JS, which is pretty ugly and need to be done for every (wrong escaped) char.

But at least the ampersand is fixed and I know what to do if there are more chars.

@secure-77
Copy link
Owner

@stellarix
Copy link
Contributor

This issue is still persist in v1.5.4, clicking on the graph links leads to non-existent file.
e.g clicking on User & Root (User & Root in Graph View) node leads to http://localhost/?link=/test 1/User & Root instead of http://localhost/?link=/test 1/User & Root

image

@secure-77 secure-77 reopened this May 28, 2023
@secure-77
Copy link
Owner

now also fixed for the global graph in 1.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants