File links does not work properly

[Diafwl]

Describe the bug
links does not work properly for files, they are behaves like normal md links, not file links

To Reproduce
Steps to reproduce the behavior:
Link a file like: [[book.pdf]] does not work
Link a file like: [[book.pdf| Book Volume 1]] does not work
Link a file like: ![[book.pdf| Book Volume 1]] does not work

Expected behavior
3 of them needed to behave like: ![[book.df]]
[Book Volume](book.pdf) does work perfectly

Desktop (please complete the following information):

• OS: Linux
• Browser Firefox
• Version 108.0.2

[secure-77]

Hi @Diafwl,

yes currently file links need to start with an ! so the only working way àt the moment is ![[book.pdf]]. This is the default behavior if you drag & drop a file into a md document in obsidian.

I will take a look if I can implement the other formats as well.

[Diafwl]

but because of regex it does not capturing ![[book.pdf| Book Volume 1]] even if this one has ! renaming with | broking file links.

[secure-77]

yes, aliases for files are not supported / implemented at the moment

[Diafwl]

if we change pdf regex to \!?(\[\[)(.*?.pdf)(\]\]) it will work with ! or without !.
i tested i little bit it seems does not broke anything.

[secure-77]

looks good 👍 then only the alias part is missing, ideally I should move the obsidian linking part into the PerliteParsdown.php but this is a little bit more work

[secure-77]

@Diafwl
This is a quick and dirty solution you can try. Just replace the pdf links section with these two:

	// pdf links with Alias
	$replaces = '<a class="internal-link" target="_blank" rel="noopener noreferrer" href="'.$path .'/'.'\\2">\\3</a>';
	$pattern = array('/(\!?\[\[)(.*?.pdf)\|(.*)(\]\])/');
	$content = preg_replace($pattern, $replaces ,$content);
	
	// pdf links without Alias
	$replaces = '<a class="internal-link" target="_blank" rel="noopener noreferrer" href="'.$path .'/'.'\\2">\\2</a>';
	$pattern = array('/(\!?\[\[)(.*?.pdf)(\]\])/');
	$content = preg_replace($pattern, $replaces ,$content);

I will check this again as soon I have some time and will make a new release

[Diafwl]

Yeah it works perfectly.

Thank you.

[secure-77]

This is fixed in version 1.5.3