Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for docker arm64 #65

Closed
phampyk opened this issue Feb 28, 2023 · 9 comments · Fixed by #93
Closed

Request for docker arm64 #65

phampyk opened this issue Feb 28, 2023 · 9 comments · Fixed by #93
Labels
enhancement New feature or request implemented / fixed on dev implemented on dev

Comments

@phampyk
Copy link

phampyk commented Feb 28, 2023

I just tried to build perlite on my raspberry pi running arm64 raspiOS and it's completely compatible with it, could it be possible to have it compiled in arm64 from github/dockerhub?
Thank you for the app, looks great, just what I was looking for.

@phampyk phampyk added the enhancement New feature or request label Feb 28, 2023
@secure-77 secure-77 added the help wanted Extra attention is needed label Mar 1, 2023
@secure-77
Copy link
Owner

Hey @phampyk
Unfortunately I have no arm64 environment here and I also don´t want to setup an emulator and testing this. The repository also contains the Dockerfile of the perlite image, so you can try to build your own image. Let me know if you get this running then we can add this to the wiki and repo.

@phampyk
Copy link
Author

phampyk commented Mar 2, 2023

Yes, I am running it right now on my raspberry pi 4, built from the dockerfile, with no issues. So it's fully compatible

@secure-77
Copy link
Owner

What are the changes you made in the docker file? Can we create a separate docker and compose file for this ? You can also create a PR if you want

@phampyk
Copy link
Author

phampyk commented Mar 2, 2023

I didn't do any changes, the basefiles you use are multi arch already so I only needed to build in my raspberry pi and it worked, nothing different at all.

@secure-77
Copy link
Owner

ah ok, but then I think I can't provide a pre build arm64 image and the best way is to build it on the target environment you are using

@phampyk
Copy link
Author

phampyk commented Mar 2, 2023

You can build multiarch when pushing to dockerhub without having to own that environment yourself. There's one here explaining how.
That way I, and anyone who wants to use it, can pull it from dockerhub every time you update or fix bugs.
And I already tested that works on arm64 so should be easy to do.
Hope this helps! I think it would be helpful to have it multi arch so more people can benefit from perlite even if it's on a raspberry pi :)

@secure-77
Copy link
Owner

ok thanks 👍 I will take a look at this as soon I have some time

@secure-77 secure-77 added To Do on the to do list and removed help wanted Extra attention is needed labels Mar 8, 2023
@catrone3
Copy link
Contributor

This actually looks like it would be quite easy to setup with a github workflow, although if you are manually creating the images still not that bad

@secure-77 secure-77 added on dev implemented on dev in progress currently in development and removed To Do on the to do list labels Jul 27, 2023
@secure-77
Copy link
Owner

implemented from version 1.5.7, there will be also always a docker image for arm. thanks to @knorr3

@secure-77 secure-77 added implemented / fixed and removed in progress currently in development labels Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented / fixed on dev implemented on dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants