Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support same document heading links #74

Closed
lennartbrandin opened this issue Apr 12, 2023 · 11 comments
Closed

Support same document heading links #74

lennartbrandin opened this issue Apr 12, 2023 · 11 comments
Labels
confirmed bug enhancement New feature or request implemented / fixed on dev implemented on dev

Comments

@lennartbrandin
Copy link
Contributor

Feature / Issue

Obsidian supports same document heading references using Wiki Links

[[#Solution]] 

Instead having the word "Solution" linking to https://perlite/?link=/github/issues/samedoclinks#Solution

It displays ">#Solution (The "> being the link and the #Solution a codeblock) linking to:
https://perlite/?link=/github/issues/<a href="#Solution

Solution

Display the correct word linking to the correct heading

Whats displayed

image

@secure-77
Copy link
Owner

fixed in release 1.5.4

@secure-77 secure-77 reopened this May 5, 2023
@secure-77
Copy link
Owner

Need to check this again and provide an example in the demo files

@secure-77
Copy link
Owner

(hopefully) finally fixed in 1.5.5

@lennartbrandin
Copy link
Contributor Author

It does not seem to work for me on 1.5.5
Behavior is as described before, i've also noticed that links inside code blocks are replaced, not sure if this is intended.

Perlite:
image

Obsidian:
image

@secure-77
Copy link
Owner

for me, this is working, you can take a look at the demo page: https://perlite.secure77.de/?link=%2FDemo%20Documents%2Fmarkdown-sample

image

image

however, can you provide me your source md file?

the problem with obsidian links in code blocks is probably a different issue

@secure-77 secure-77 reopened this May 31, 2023
@lennartbrandin
Copy link
Contributor Author

lennartbrandin commented May 31, 2023

Source.md

@secure-77
Copy link
Owner

can confirm the issue, in my test file I have a whitespace behind the link, only then it is working... I will try to fix this and provide a new release

image

@secure-77 secure-77 added To Do on the to do list and removed implemented / fixed labels May 31, 2023
@secure-77
Copy link
Owner

please try again with the 1.5.6 release 🙏

@lennartbrandin
Copy link
Contributor Author

image
The first link is now as imagined, the 2nd one links to the root of the containing folder. ([[#Test|Mit Title]])

@secure-77 secure-77 added on dev implemented on dev and removed To Do on the to do list labels Jul 27, 2023
@secure-77
Copy link
Owner

this is implemented on the dev branche, will merge it in the next days to main

@secure-77
Copy link
Owner

fixed in 1.5.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug enhancement New feature or request implemented / fixed on dev implemented on dev
Projects
None yet
Development

No branches or pull requests

2 participants