Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Don't allow installation of app to repos with unsupported languages #168

Open
ericwb opened this issue Mar 31, 2019 · 0 comments
Open

Don't allow installation of app to repos with unsupported languages #168

ericwb opened this issue Mar 31, 2019 · 0 comments
Labels
bug Something isn't working task-size-large
Milestone

Comments

@ericwb
Copy link
Collaborator

ericwb commented Mar 31, 2019

Describe the bug
Precaution currently only supports scanning Python and Go, with JavaScript coming soon. However, Precaution has no reason to be installed to repos that use only languages Precaution doesn't support. For example, if the repo uses only Java, there currently is no point to installing Precaution.

We need some kind of compatibility check prior to adding our App to a repo. There is a way to determine the languages for a repo using this API.

https://developer.github.com/v3/repos/#list-languages

But I don't know whether we can tell GitHub to abort installation if the repo doesn't meet our requirements.

To Reproduce
Steps to reproduce the behavior:

  1. Choose a repo that is all Java based
  2. Install Precaution
  3. Notice nothing prevents this and now Precaution does nothing but monitor PRs.

Expected behavior
Shouldn't install Precaution on repos unsupported by it.

Screenshots
n/a

Additional context
n/a

@ericwb ericwb added the bug Something isn't working label Mar 31, 2019
@joshuagl joshuagl added this to the Near Future milestone May 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working task-size-large
Projects
None yet
Development

No branches or pull requests

3 participants