diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3bc4fe80..b6724fae 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,12 +2,14 @@ This file describes the process for contributing to `seda-chain`. + ## Starting First and foremost, [fork](https://github.com/sedaprotocol/seda-chain/fork) the repository. Then please read the [developing instructions](DEVELOPING.md) for setting up your environment. + ## Commits Your commits must follow specific guidelines. @@ -23,16 +25,18 @@ Sign all commits with a GPG key. GitHub has extensive documentation on how to: - [Sign](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) your commits. -### Convention +### Conventional Commits All commits are to follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard. Commit messages should always be meaningful. + ## Error Handling If you already have an error you can return, just return it. If you would like -to add context to the error, use `errorsmod.Wrapf()`. For instance: +to add context to the error, use `errorsmod.Wrap()` or `errorsmod.Wrapf()`. +For instance: ```go import ( @@ -64,10 +68,12 @@ func (m *MsgCreateVestingAccount) ValidateBasic() error { } ``` + ## Formatting and Cleanliness Please run `make lint` before making a commit to format the code. + ## Creating a Pull Request For creating the PR, please follow the instructions below. diff --git a/x/wasm-storage/keeper/msg_server.go b/x/wasm-storage/keeper/msg_server.go index 75096373..69e550ab 100644 --- a/x/wasm-storage/keeper/msg_server.go +++ b/x/wasm-storage/keeper/msg_server.go @@ -59,6 +59,7 @@ func (m msgServer) StoreDataRequestWasm(goCtx context.Context, msg *types.MsgSto ctx.EventManager().EmitEvent( sdk.NewEvent( types.EventTypeStoreDataRequestWasm, + sdk.NewAttribute(types.AttributeSender, msg.Sender), sdk.NewAttribute(types.AttributeWasmHash, hashString), ), ) @@ -106,6 +107,7 @@ func (m msgServer) StoreExecutorWasm(goCtx context.Context, msg *types.MsgStoreE ctx.EventManager().EmitEvent( sdk.NewEvent( types.EventTypeExecutorWasm, + sdk.NewAttribute(types.AttributeSender, msg.Sender), sdk.NewAttribute(types.AttributeWasmHash, hashString), ), ) diff --git a/x/wasm-storage/types/events.go b/x/wasm-storage/types/events.go index 6193c542..4a4081f3 100644 --- a/x/wasm-storage/types/events.go +++ b/x/wasm-storage/types/events.go @@ -6,4 +6,5 @@ const ( EventTypeWasmExpiration = "wasm_expiration" AttributeWasmHash = "wasm_hash" + AttributeSender = "sender" )