Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Group navigation issues #1677

Open
3 tasks
horacioh opened this issue Mar 12, 2024 · 6 comments
Open
3 tasks

Bug: Group navigation issues #1677

horacioh opened this issue Mar 12, 2024 · 6 comments
Assignees
Labels
priority: high Critical to have scope: desktop app The Electron app type: bug Something isn't working

Comments

@horacioh
Copy link
Collaborator

⚠️ very unstructured feedback. sorry!!

Issues

  • the embeds created in the navigation document should be pointing to the latest version of the document
  • when multiple editors edit this document, is easy to get into branches of it and only publishing part of the whole change. This makes only the "last change" available and all the other changes ignored.
  • I really believe that the navigation document should be available. maybe the frontpage is the navigation document (as discussed with @GaboHBeaumont)
@horacioh horacioh added type: bug Something isn't working scope: desktop app The Electron app priority: high Critical to have labels Mar 12, 2024
@ericvicenti
Copy link
Collaborator

  1. this is an easy fix, I'll do that
  2. this is an old issue that has nothing to do with the new group nav sidebar, right?
  3. we can offer something in the group dropdown to take you to the navigation document. unless you prefer something more visible? I actually don't think we should allow people to navigate to the nav document because it may be very confusing to people

@horacioh
Copy link
Collaborator Author

  1. yes, we need rebase essentially. but because the navigation document is hidden is harder to do. that's why I advocate to make it visible.
  2. yes, more visible. the navigation should be generated from the headings of the documents. and the frontpage should be the root level for each group. we can talk about this in the meeting!

@ericvicenti
Copy link
Collaborator

  1. I believe the nav document should not include the version at all
  2. I don't understand but we can talk about it later

@horacioh
Copy link
Collaborator Author

@ericvicenti

  1. I believe the nav document should not include the version at all

I believe this is wrong considering we have the latest param now. having the version in the URL is a good hint for other reasons (like capturing when this document was added for example)

  1. sure we can chat tomorrow!

@horacioh
Copy link
Collaborator Author

@ericvicenti I noticed another thing:

  • If the group does not have a navigation document, it does not make sense to show the navigation sidebar. we can default to show it as before. (all content below the frontpage).

@ericvicenti
Copy link
Collaborator

@horacioh we are adding a group feed this week, so I think we need the sidebar for all groups 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Critical to have scope: desktop app The Electron app type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants