source macro: preserve new lines (#1372)

Co-authored-by: Michael Taranto <michaeltaranto@users.noreply.github.com>
seek-oss · Oct 12, 2023 · 3f8a82c · 3f8a82c
1 parent 5345268
commit 3f8a82c
Show file tree

Hide file tree

Showing 4 changed files with 93 additions and 2 deletions.
diff --git a/.changeset/red-melons-compete.md b/.changeset/red-melons-compete.md
@@ -0,0 +1,33 @@
+---
+'@braid-design-system/source.macro': patch
+---
+
+Preserve new lines in the output code
+
+Before:
+```ts
+const responsiveValue = useResponsiveValue()
+const isMobile = responsiveValue({
+  mobile: true,
+  tablet: false,
+})
+const isDesktopOrAbove = responsiveValue({
+  mobile: false,
+  desktop: true,
+})
+```
+
+After:
+```ts
+const responsiveValue = useResponsiveValue()
+
+const isMobile = responsiveValue({
+  mobile: true,
+  tablet: false,
+})
+
+const isDesktopOrAbove = responsiveValue({
+  mobile: false,
+  desktop: true,
+})
+```
diff --git a/packages/source.macro/__snapshots__/source.macro.test.ts.snap b/packages/source.macro/__snapshots__/source.macro.test.ts.snap
@@ -56,7 +56,48 @@ const foo = 'bar';
 
 `;
 
-exports[`source.macro 4. code only: 4. code only 1`] = `
+exports[`source.macro 4. with new lines: 4. with new lines 1`] = `
+
+
+import source from './source.macro';
+
+const options = source(() => {
+  sideEffect();
+
+  return [
+    { value: "1", label: "Option 1" },
+    { value: "2", label: "Option 2" },
+    { value: "3", label: "Option 3" },
+  ];
+});
+      
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+const options = {
+  code: '() => {\\n  sideEffect();\\n\\n  return [\\n  { value: "1", label: "Option 1" },\\n  { value: "2", label: "Option 2" },\\n  { value: "3", label: "Option 3" }];\\n\\n}',
+  value: () => {
+    sideEffect();
+    return [
+      {
+        value: '1',
+        label: 'Option 1',
+      },
+      {
+        value: '2',
+        label: 'Option 2',
+      },
+      {
+        value: '3',
+        label: 'Option 3',
+      },
+    ];
+  },
+};
+
+`;
+
+exports[`source.macro 5. code only: 5. code only 1`] = `
 
 
 import source from './source.macro';

diff --git a/packages/source.macro/source.macro.cjs b/packages/source.macro/source.macro.cjs
@@ -9,7 +9,9 @@ module.exports = createMacro(
 
     references.default.forEach(({ parentPath }) => {
       const value = parentPath.node.arguments[0] || t.identifier('undefined');
-      const code = t.stringLiteral(generate(value).code);
+      const code = t.stringLiteral(
+        generate(value, { retainLines: true }).code.replace(/^\n+/, ''),
+      );
 
       return parentPath.replaceWith(
         codeOnly

diff --git a/packages/source.macro/source.macro.test.ts b/packages/source.macro/source.macro.test.ts
@@ -39,6 +39,21 @@ pluginTester({
         const foo = 'bar';
       `,
     },
+    'with new lines': {
+      code: /* ts */ `
+        import source from './source.macro';
+
+        const options = source(() => {
+          sideEffect();
+
+          return [
+            { value: "1", label: "Option 1" },
+            { value: "2", label: "Option 2" },
+            { value: "3", label: "Option 3" },
+          ];
+        });
+      `,
+    },
     'code only': {
       pluginOptions: { source: { codeOnly: true } },
       code: /* ts */ `