-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Columns): Add Columns and Column components #101
Conversation
Just pushed a big change to the API, to future proof things a bit. We now have a matching For example: <Columns>
<Column>...</Column>
<Column>...</Column>
<Column>...</Column>
</Columns> This allows us to add props to each |
'.column': { | ||
flexBasis: 0, | ||
flexGrow: 1, | ||
minWidth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems flexBasis
work as the arbitrary minWidth
under flexbox 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this was a lesson we learnt from the seek-style-guide
about how min-width
is handled by flex elements.
Example usage: