Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): Use relative path for type imports #144

Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix(Button): Use relative path for type imports #144

merged 1 commit into from
Mar 20, 2019

Conversation

michaeltaranto
Copy link
Contributor

Fix the importing of types in Button by using relative paths. This meant the component was functional in braid but broken for consumers. Also found the same issue in the makeBoxShadow atom.

@michaeltaranto michaeltaranto requested a review from a team as a code owner March 20, 2019 03:20
@michaeltaranto michaeltaranto merged commit 75a2d89 into master Mar 20, 2019
@michaeltaranto michaeltaranto deleted the button-fix branch March 20, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcompiles mattcompiles mattcompiles approved these changes

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeltaranto @markdalgleish @mattcompiles