fix(ChecklistCard): Ensure divider doesn’t cover error border #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengtzu
reviewed
Feb 13, 2019
| </Fragment> | ||
| ))} | ||
| {React.Children.map(children, (child, i) => { | ||
| if (typeof child !== 'object') { |
There was a problem hiding this comment.
What's this guarding against specifically?
There was a problem hiding this comment.
Children can be primitive types, like string or number, which don't have a props property.
mengtzu
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Note: This introduces a double border between checkboxes when multiple error states are stacked, but this is being treated as the lesser of two evils for now.