-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Shrink API surface area, remove ChecklistCard #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengtzu
approved these changes
Feb 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉
BREAKING CHANGE: Removed ChecklistCard
(EDIT: Moved release notes up to the original PR description) |
markdalgleish
changed the title
fix: Shrink API surface area
fix: Shrink API surface area, remove ChecklistCard
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a breaking change, but we're releasing it as a
fix
to maintain the alphav0.0.x
versioning scheme.Component Inheritance
High level components no longer inherit the props of lower level components.
Most notably, any white space props will need to be hoisted out into a separate usage of
Box
. For example:Alternatively, you can replace your component with a lower level
Box
component:This is a very deep change to the system, so please reach out to Braid maintainers if you need help.
ChecklistCard
We have removed the
ChecklistCard
component. If needed, it can be implemented manually in your app withCard
andDivider
components. For example:Since
Card
no longer inherits fromBox
, if you customised theCard
in any way, you will need to use aBox
instead: