Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button, ButtonLink: Default to ghost neutral in non-legacy themes #1363

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

michaeltaranto
Copy link
Contributor

Button, ButtonLink: Default to ghost neutral in non-legacy themes

By default, a button now has a neutral tone and uses the ghost variant, allowing the visual prominence to be increased or decreased as required, enabling colour to be applied as accents and with purpose, rather than by default.

<Button />
// => variant="ghost" & tone="neutral"

To compliment this, when a tone is purposefully applied, the default variant is becomes solid to maximise it’s impact — allowing the visual prominence to be reduced as needed.

<Button tone="brandAccent" />
// => variant="solid" & tone="brandAccent"

No change for apac and seekBusiness consumers

Given the fundamental change in approach to colour and usage of such a core component, this change has been isolated newer themes and does not impact apac and seekBusiness consumers.

These themes will continue to have a tone of formAccent and a solid variant by default, allowing consumers to adopt this new approach as part of the design uplift when migrating to an updated theme, e.g. seekJobs.

Button update

@michaeltaranto michaeltaranto requested a review from a team as a code owner September 14, 2023 04:56
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: 9fb0f1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

michaeltaranto and others added 3 commits September 14, 2023 16:02
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@michaeltaranto michaeltaranto merged commit 5b41eff into master Sep 18, 2023
5 checks passed
@michaeltaranto michaeltaranto deleted the button-defaults branch September 18, 2023 00:20
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants