Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #1364

Merged
merged 1 commit into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .changeset/curly-gorillas-pull.md

This file was deleted.

26 changes: 26 additions & 0 deletions packages/braid-design-system/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,31 @@
# braid-design-system

## 32.12.0

### Minor Changes

- **Button, ButtonLink:** Default to neutral ghost in non-legacy themes ([#1363](https://github.com/seek-oss/braid-design-system/pull/1363))

By default, a button now has a `neutral` tone and uses the `ghost` variant, allowing the visual prominence to be increased or decreased as required, enabling colour to be applied as accents and with purpose, rather than by default.

```jsx
<Button />
// => tone="neutral" & variant="ghost"
```

To compliment this, when a `tone` is purposefully applied, the default variant becomes `solid` to maximise its impact — allowing the visual prominence to be reduced as needed.

```jsx
<Button tone="brandAccent" />
// => tone="brandAccent" & variant="solid"
```

### No change for `apac` and `seekBusiness` consumers

Given the fundamental change in approach to colour and usage of such a core component, this change has been isolated to newer themes and **does not impact `apac` and `seekBusiness` consumers**.

These themes will continue to have a tone of `formAccent` and a `solid` variant by default, allowing consumers to adopt this new approach as part of the design uplift when migrating to an updated theme, e.g. `seekJobs`.

## 32.11.0

### Minor Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/braid-design-system/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "braid-design-system",
"version": "32.11.0",
"version": "32.12.0",
"description": "Themeable design system for the SEEK Group",
"homepage": "https://seek-oss.github.io/braid-design-system/",
"bugs": {
Expand Down
12 changes: 12 additions & 0 deletions site/src/componentUpdates.json
Original file line number Diff line number Diff line change
Expand Up @@ -3547,5 +3547,17 @@
"summary": "**Button, ButtonLink:** Provide `formAccent` as the name for undefined tone\n\nFormalise the name of the `undefined` tone as `formAccent`, making it more discoverable as an accent available for increased prominence.\n\nNote: Consumers should only apply this tone where an action should be emphasized explicitly. The `undefined` value is still valid for buttons that should follow the default button style of the theme.\n\n**EXAMPLE USAGE:**\n```jsx\n<Button tone=\"formAccent\">\n ...\n</Button>\n```"
}
]
},
{
"version": "32.12.0",
"updates": [
{
"updated": [
"Button",
"ButtonLink"
],
"summary": "**Button, ButtonLink:** Default to neutral ghost in non-legacy themes\n\nBy default, a button now has a `neutral` tone and uses the `ghost` variant, allowing the visual prominence to be increased or decreased as required, enabling colour to be applied as accents and with purpose, rather than by default.\n\n```jsx\n<Button />\n// => tone=\"neutral\" & variant=\"ghost\"\n```\n\nTo compliment this, when a `tone` is purposefully applied, the default variant becomes `solid` to maximise its impact — allowing the visual prominence to be reduced as needed.\n\n```jsx\n<Button tone=\"brandAccent\" />\n// => tone=\"brandAccent\" & variant=\"solid\"\n```\n\n### No change for `apac` and `seekBusiness` consumers\n\nGiven the fundamental change in approach to colour and usage of such a core component, this change has been isolated to newer themes and **does not impact `apac` and `seekBusiness` consumers**.\n\nThese themes will continue to have a tone of `formAccent` and a `solid` variant by default, allowing consumers to adopt this new approach as part of the design uplift when migrating to an updated theme, e.g. `seekJobs`."
}
]
}
]