Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonIcon: Add formAccent tone #1508

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

michaeltaranto
Copy link
Contributor

Introduces support for the formAccent tone on ButtonIcon.

The new tone sits alongside the existing neutral tone, while the secondary tone is now deprecated and to be removed in a future version (see Migration Guide below).

EXAMPLE USAGE:

<ButtonIcon tone="formAccent" icon={<IconAdd />} />

MIGRATION GUIDE:

For consumers of the now deprecated secondary tone, you can pro-actively migrate away from it by moving the tone to the icon itself:

 <ButtonIcon
-  tone="secondary"
-  icon={<IconAdd />}
+  icon={<IconAdd tone="secondary" />}

@michaeltaranto michaeltaranto requested a review from a team as a code owner June 7, 2024 05:08
Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: f42adec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/kind-balloons-cough.md Outdated Show resolved Hide resolved
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@michaeltaranto michaeltaranto merged commit e660f75 into master Jun 11, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the buttonicon-formaccent branch June 11, 2024 00:39
@seek-oss-ci seek-oss-ci mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants