Migrate to sku version 13, and fix minor bug in useToast for React 18.3.0
#1534
Conversation
GitButler WIP Commit
In ignore references
🦋 Changeset detectedLatest commit: 7e79f8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Michael Taranto <michaeltaranto@users.noreply.github.com>
| // Todo - shouldn't need eslint disable | ||
| // eslint-disable-next-line import/no-unresolved |
There was a problem hiding this comment.
Any ideas on what is happening here?
There was a problem hiding this comment.
Not sure currently, we have the same issue in Metropolis. Even though the IDE is able to find the plugin it shows a lint error
There was a problem hiding this comment.
I think it's an eslint-plugin-import issue import-js/eslint-plugin-import#1810.
Supposedly using eslint-import-resolver-typescript fixes it, but we already use it in eslint-config-seek, so I'm not sure why it's not working. Could be because this is in a .js file, so the typescript resolver doesn't get used.
Not worth fussing over IMO.
felixhabib
force-pushed
the
sku-13-migration-2
branch
from
3999cb7
to
5b5c691
Compare
Migrating to sku 13, involving a few supporting changes:
dist-storybookuses with the defaultstorybook-staticuseToast. Removekeyas a provided value in one use ofaddToastto prevent warning in React 18.3.0 (Warn when spreading key)