-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge: Enable usage inside typographic components #1547
Conversation
🦋 Changeset detectedLatest commit: 904da1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth updating the Badge
vertical bleed docs, i.e. do we want encourage putting the badge in the heading rather than bleeding?
Also, is the badge meant to be vertically centered at all heading sizes? It doesn't appear to be the case.
EDIT: The screenshot below is of the apac
theme. It's perfectly aligned in seekJobs
.
A
Badge
can now be nested inside typographic components, e.g.Text
andHeading
, as an inline element alongside text.Previously a
Badge
had to be aligned against text using anInline
component, which would result in theBadge
dropping below the text when the copy wrapped.EXAMPLE USAGE: