Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuRenderer, OverflowMenu: Limit the menu height #1567

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

michaeltaranto
Copy link
Contributor

Limit the menu to show a maximum of around 10 items before scrolling (a little less so its evident there is more to scroll to).

@michaeltaranto michaeltaranto requested a review from a team as a code owner August 26, 2024 00:09
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 039d470

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/bright-nails-cry.md Outdated Show resolved Hide resolved
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@michaeltaranto michaeltaranto merged commit 06093c1 into master Aug 26, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the menu-height-limit branch August 26, 2024 01:54
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants