Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disclosure: Add size support #1633

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Disclosure: Add size support #1633

merged 5 commits into from
Oct 21, 2024

Conversation

michaeltaranto
Copy link
Contributor

Introduce the size prop to the Disclosure component, providing the same options as the Text component.

EXAMPLE USAGE:

<Disclosure
  size="small"
>
  ...
</Disclosure>

@michaeltaranto michaeltaranto requested a review from a team as a code owner October 20, 2024 22:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2e7d245

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhabib
Copy link
Contributor

While here, is there a reason we have the Stack in the Disclosure playroom snippet but not in any docs examples?

@michaeltaranto michaeltaranto merged commit 5d9d8a4 into master Oct 21, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the disclosure-small branch October 21, 2024 03:02
@seek-oss-ci seek-oss-ci mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixhabib felixhabib felixhabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeltaranto @felixhabib