Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconLicence: Add component #1640

Merged
merged 4 commits into from
Oct 29, 2024
Merged

IconLicence: Add component #1640

merged 4 commits into from
Oct 29, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Oct 29, 2024 •
edited
Loading

Add IconLicence to icon suite

EXAMPLE USAGE:

<IconLicence />

@felixhabib felixhabib requested a review from a team as a code owner October 29, 2024 03:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 93a376d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michaeltaranto
Copy link
Contributor

Ah the licence vs license discussion!

I was expecting licence, I think we follow British unless it follows CSS, e.g. backgroundColor.

@felixhabib
Copy link
Contributor Author

@michaeltaranto ahh yep 😄, wasn't even aware of this spelling

@felixhabib felixhabib changed the title IconLicense: Add component IconLicence: Add component Oct 29, 2024
@felixhabib @michaeltaranto
Update keywords
93a376d 
Co-authored-by: Michael Taranto <michaeltaranto@users.noreply.github.com>
@felixhabib felixhabib enabled auto-merge (squash) October 29, 2024 03:58
@felixhabib felixhabib merged commit 74ee5a5 into master Oct 29, 2024
6 checks passed
@felixhabib felixhabib deleted the icon-license branch October 29, 2024 04:00
@seek-oss-ci seek-oss-ci mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeltaranto michaeltaranto michaeltaranto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixhabib @michaeltaranto