Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Commit

Permalink
fix(less): Add missing Less dependency (#15)
Browse files Browse the repository at this point in the history
When the webpack 1 decorators were removed from seek-style-guide, so too was the style guide's Less dependency. This package didn't include Less, which meant it failed to build on the latest major style guide version.
  • Loading branch information
markdalgleish authored Oct 10, 2017
1 parent b239a7f commit b0456e3
Show file tree
Hide file tree
Showing 12 changed files with 19 additions and 832 deletions.
18 changes: 9 additions & 9 deletions autoprefixer.config.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
module.exports = {
browsers: [
'> 1%',
'Last 2 versions',
'IE >= 10',
'Edge >= 13',
'Safari >= 6',
'iOS >= 6',
'Samsung >= 4'
]
browsers: [
'> 1%',
'Last 2 versions',
'IE >= 10',
'Edge >= 13',
'Safari >= 6',
'iOS >= 6',
'Samsung >= 4'
]
};
8 changes: 6 additions & 2 deletions incorrectStyleGuidePath.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ const path = require('path');

const notTesting = process.env.NODE_ENV !== 'test';

const explicitlyResolvedIncorrectPath = path.resolve(__dirname, 'node_modules/seek-style-guide');
const explicitlyResolvedIncorrectPath = path.resolve(
__dirname,
'node_modules/seek-style-guide'
);
const resolvedPath = require.resolve('seek-style-guide');

module.exports = notTesting && resolvedPath.indexOf(explicitlyResolvedIncorrectPath) > -1;
module.exports = notTesting &&
resolvedPath.indexOf(explicitlyResolvedIncorrectPath) > -1;
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"babel-preset-react": "^6.23.0",
"chalk": "^1.1.3",
"css-loader": "^0.26.1",
"less": "^2.7.2",
"less-loader": "^2.2.3",
"postcss-loader": "^1.3.1",
"raw-loader": "^0.5.1",
Expand Down Expand Up @@ -69,7 +70,7 @@
"react-dom": "^15.4.2",
"react-helmet": "^4.0.0",
"react-isolated-scroll": "^0.1.0",
"seek-style-guide": "18.0.0",
"seek-style-guide": "31.0.2",
"semantic-release": "^6.3.2",
"static-site-generator-webpack-plugin": "^3.1.2",
"validate-commit-msg": "^2.11.2",
Expand Down
3 changes: 2 additions & 1 deletion test/app/App.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react';
import { Text } from 'seek-style-guide/react';

export default () => <span>HKJLHSNFLKNDKDFJPKIDSNFN</span>;
export default () => <Text>Hello world</Text>;
19 changes: 0 additions & 19 deletions test/app/components/Playground/Atoms/IconButton/IconButton.js

This file was deleted.

16 changes: 0 additions & 16 deletions test/app/components/Playground/Atoms/IconButton/IconButton.less

This file was deleted.

21 changes: 0 additions & 21 deletions test/app/components/Playground/Atoms/Tab/Tab.js

This file was deleted.

29 changes: 0 additions & 29 deletions test/app/components/Playground/Atoms/Tab/Tab.less

This file was deleted.

65 changes: 0 additions & 65 deletions test/app/components/Playground/Atoms/TextLink/TextLink.js

This file was deleted.

38 changes: 0 additions & 38 deletions test/app/components/Playground/Atoms/TextLink/TextLink.less

This file was deleted.

Loading

0 comments on commit b0456e3

Please sign in to comment.