Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

fix(decorateClientConfig): Make config object optional #27

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

dborysiewicz
Copy link
Contributor

No description provided.

@markdalgleish markdalgleish changed the title fix(decorateClientConfig): Default param for option & removed incorrect autoprefixerConfig param fix(decorateClientConfig): Make config object optional Oct 26, 2017
@markdalgleish
Copy link
Member

Just changed the title so that it's more user-facing. Make sure you update the commit message when merging :)

@@ -212,7 +212,7 @@ const decorateServerConfig = (config, options) => {
});
}

const postcssPlugins = ({ cssSelectorPrefix }, autoprefixerConfig) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, I would have thought the linter would have picked this up, since we're shadowing an existing variable 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth double checking the lint rules.

@dborysiewicz dborysiewicz merged commit c66eaf2 into master Oct 26, 2017
@dborysiewicz dborysiewicz deleted the fix-no-options branch October 26, 2017 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants