Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color modes for Strix G513RM #2634

Closed
2 tasks done
fram446742 opened this issue May 25, 2024 · 6 comments
Closed
2 tasks done

Color modes for Strix G513RM #2634

fram446742 opened this issue May 25, 2024 · 6 comments
Labels

Comments

@fram446742
Copy link

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

  1. I've noticed that some color modes supported by my laptop are currently inactive. The model that I have, has per-key keyboard illumination with extra modes that can be enabled in Armoury Crate.

Describe the solution you'd like

I've tried compiling the app with modified code (changing isStrixLimitedRGB), and all modes function except for heatmap and ambient.

It would also be great to have an option to enable "random colors" for modes that currently lack it, such as breathing, star, rain, highlight, laser, ripple, stroboscopic, comet, or flash.

and if you want to see the changes in a repo I forked this one, here is the link:
https://github.com/fram446742/g-helper

or if you prefer here is the build that I made:
g-helper.zip

Describe alternatives you've considered

No response

Device and Model

Asus ROG Strix G15 (2022) G513RM

Additional information.

No response

@seerge
Copy link
Owner

seerge commented May 25, 2024

@fram446742 hello, you don't really need to modify any code for that.

Unfortunately your model (G513RM) exists in both per-key and 4-zone versions, so it's not possible to automatically detect what modes to show. By default it would be limited list.

You can just add following line to config.json

"per_key_rgb" : 1,

And it should threat your device as per-key RGB :)

@fram446742
Copy link
Author

Thank you very much. I didn't know that that config would work in this case. I'll give it a try.

@fram446742
Copy link
Author

Sorry for the inconvenience, but I added it and it doesn't seem to change anything.

image

I added it, tryed deleting the files so new ones were generated and obviously used the original version, not mine.
image

This is what my version shows:
image

@seerge
Copy link
Owner

seerge commented May 25, 2024

@fram446742 can you try this build ?

GHelper.zip

@fram446742
Copy link
Author

It does work, thanks. What is the difference with the one that is posted on the releases page?

@seerge
Copy link
Owner

seerge commented May 25, 2024

@fram446742 it was 2 separate flags

  • Limited RGB affecting what modes are available in a dropdown
  • 4-zone RGB (opposite to per-key RGB) - affecting how exactly app would set dynamic backlight colors for Ambient / Heatmap

In new build I have just extended per_key_rgb setting effect on both options (as it should be probably)

Closing as resolved then.

@seerge seerge closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants