Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using trackDeepLinks() Validate if the intent has data to avoid an NPE #657

Closed
pjcyber opened this issue May 5, 2020 · 1 comment
Closed

using trackDeepLinks() Validate if the intent has data to avoid an NPE #657

pjcyber opened this issue May 5, 2020 · 1 comment

Comments

@pjcyber
Copy link

pjcyber commented May 5, 2020

The SDK is assuming if the activity has an intent it must have an URL associated. with is a wrong assumption considering activities can be launched using intent for simple data.

analytics-android/analytics/src/main/java/com/segment/analytics/AnalyticsActivityLifecycleCallbacks.java

Line 101 in a9fefda

Uri uri = intent.getData();

@pjcyber pjcyber changed the title Validate if the intent has data to avoid an NPE using trackDeepLinks() Validate if the intent has data to avoid an NPE May 5, 2020
@niallzato niallzato mentioned this issue May 28, 2020
Merged
@prayansh
Copy link
Contributor

prayansh commented Jun 2, 2020

@pjcyber #663 should fix this issue. Thanks for reporting

@prayansh prayansh closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjcyber @prayansh