Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper use of -Warc-performSelector-leaks #713

Closed
casey-juul opened this issue Sep 12, 2017 · 2 comments
Closed

Improper use of -Warc-performSelector-leaks #713

casey-juul opened this issue Sep 12, 2017 · 2 comments
Labels
bug jira

Comments

@casey-juul
Copy link

In SEGAnalyticsConfiguration line 61:

The code is disabling the performSelector leak warning. This is bad practice and can lead to a leak. Instead, use the IMP invocations.

You can see the reasoning and code samples here.
@f2prateek
Copy link
Contributor

Tracking internally in JIRA — https://segment.atlassian.net/browse/LIB-126

@bsneed
Copy link
Contributor

bsneed commented May 6, 2020

Fixed in #884.

@bsneed bsneed closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug jira
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bsneed @f2prateek @casey-juul