New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FALSE negative: www.google.de #26

Open

ffischer1984 opened this issue Sep 20, 2018 · 1 comment

ffischer1984 commented Sep 20, 2018

IMHO it should be an url ;)

ffischer1984 changed the title ~~www.google.de is not an url~~ FALSE negative: www.google.de

Contributor

davisjam commented Sep 20, 2018 •

edited

Loading

www.google.com is also not a URL.

From the source:

/**
 * RegExps.
 * A URL must match #1 and then at least one of #2/#3.
 * Use two levels of REs to avoid REDOS.
 */

var protocolAndDomainRE = /^(?:\w+:)?\/\/(\S+)$/;

I believe this project follows the definition of URL given in RFC 1738 (relevant bit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment