fix(scoring): tourmanent scoring should behave more consistently now.…

… also, matches that are too far in the past can no longer be scored as a result of this.

the pointer icon has also been moved to the icon instead of being on the whole row, as that causes a bad association between clickability and not

closes #110

src/js/controllers/tournaments/inProgressCtrl.js

@@ -178,10 +178,9 @@ site.controller('inProgressController', ($scope, $timeout, EnsureLoggedIn, Sideb
     $scope.getName = (idx) => TournamentInformation.playerName($scope.bucket[idx]);
 
     $scope.invalidMatch = (match) => !$scope.trn.isPlayable(match);
+
     $scope.scoresEqual = (match) => {
-      if(match.score && match.score.length === 1 || _.filter(match.score, _.isNumber).length !== match.p.length) return true;
-      const sorted = _.sortBy(match.score).reverse();
-      return sorted[0] === sorted[1];
+      return $scope.trn.unscorable(match.id, match.score);
     };
 
     $scope.confirmScore = (match) => {

src/scss/site.scss

@@ -227,7 +227,11 @@ station {
         }
 
         .confirm-score {
-          cursor: pointer;
+
+          ng-md-icon[icon="check_circle"] {
+            cursor: pointer;
+          }
+
           @include all-widths(24px);
         }