Start using the skylark parser where possible

This is the low-hanging fruit, but starts to remove the need
for python to be installed on developer machines when building
Selenium using buck.

.buckconfig

@@ -2,6 +2,9 @@
   src_roots = /java/client/src, /java/client/test, /java/server/src, /java/server/test
   source_level = 8 
   target_level = 8
+  jar_spool_mode = direct_to_jar
+  abi_generation_mode = source_with_deps
+  compile_against_abis = true
 
 [project]
   ignore = \
@@ -11,9 +14,18 @@
       java/client/build, \
       java/server/build
 
+[build]
+  metadata_storage = sqlite
+
 [cache]
   mode = dir
 
+[parser]
+  polyglot_parsing_enabled = true
+
+[resources]
+  resource_aware_scheduling_enabled = true
+
 [test]
   # Maximum timeout of 10 minutes per test (since each suite counts as a test)
   timeout = 600000

dotnet/BUCK

@@ -1,4 +1,5 @@
-include_defs('//dotnet/SELENIUM_DOTNET_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//dotnet:selenium-dotnet-version.bzl", "SE_VERSION")
 
 export_file(
   name = 'keyfile',

dotnet/SELENIUM_DOTNET_VERSION → dotnet/selenium-dotnet-version.bzl

@@ -1,2 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
+
 SE_VERSION = '3.6.0'
 ASSEMBLY_VERSION = '3.6.0.0'

dotnet/src/support/BUCK

@@ -1,4 +1,5 @@
-include_defs('//dotnet/SELENIUM_DOTNET_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//dotnet:selenium-dotnet-version.bzl", "SE_VERSION", "ASSEMBLY_VERSION")
 
 genrule(
   name = 'net35',
@@ -41,16 +42,16 @@ genrule(
     ':netstandard2.0'
   ],
   cmd_exe = 
-    'setlocal EnableDelayedExpansion && '\
-    '(if not exist %OUT% mkdir %OUT%) && '\
-    'for %%G in (%SRCS%) do ('\
-      'set target_dir=%%G&& '\
-      'for %%H in (!target_dir!) do ('\
-        'set platform_moniker=%%~nxH&& '\
-        '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && '\
-        'copy !target_dir!\\WebDriver.Support.dll %OUT%\\!platform_moniker! &&'\
-        'copy !target_dir!\\WebDriver.Support.xml %OUT%\\!platform_moniker!'\
-      ')'\
+    'setlocal EnableDelayedExpansion && ' +
+    '(if not exist %OUT% mkdir %OUT%) && ' +
+    'for %%G in (%SRCS%) do (' +
+      'set target_dir=%%G&& ' +
+      'for %%H in (!target_dir!) do (' +
+        'set platform_moniker=%%~nxH&& ' +
+        '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && ' +
+        'copy !target_dir!\\WebDriver.Support.dll %OUT%\\!platform_moniker! &&' +
+        'copy !target_dir!\\WebDriver.Support.xml %OUT%\\!platform_moniker!' +
+      ')' +
     ')',
   out = 'lib'
 )
@@ -100,16 +101,16 @@ genrule(
     ':netstandard2.0_strongnamed'
   ],
   cmd_exe = 
-    'setlocal EnableDelayedExpansion && '\
-    '(if not exist %OUT% mkdir %OUT%) && '\
-    'for %%G in (%SRCS%) do ('\
-      'set target_dir=%%G&& '\
-      'for %%H in (!target_dir!) do ('\
-        'set platform_moniker=%%~nxH&& '\
-        '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && '\
-        'copy !target_dir!\\WebDriver.Support.dll %OUT%\\!platform_moniker! &&'\
-        'copy !target_dir!\\WebDriver.Support.xml %OUT%\\!platform_moniker!'\
-      ')'\
+    'setlocal EnableDelayedExpansion && ' +
+    '(if not exist %OUT% mkdir %OUT%) && ' +
+    'for %%G in (%SRCS%) do (' +
+      'set target_dir=%%G&& ' +
+      'for %%H in (!target_dir!) do (' +
+        'set platform_moniker=%%~nxH&& ' +
+        '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && ' +
+        'copy !target_dir!\\WebDriver.Support.dll %OUT%\\!platform_moniker! &&' +
+        'copy !target_dir!\\WebDriver.Support.xml %OUT%\\!platform_moniker!' +
+      ')' +
     ')',
   out = 'lib'
 )

dotnet/src/webdriver/BUCK

@@ -1,4 +1,5 @@
-include_defs('//dotnet/SELENIUM_DOTNET_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//dotnet:selenium-dotnet-version.bzl", "SE_VERSION", "ASSEMBLY_VERSION")
 
 genrule(
   name = 'net35',
@@ -57,22 +58,22 @@ genrule(
     ':netstandard2.0'
   ],
   cmd_exe = 
-    'setlocal EnableDelayedExpansion && '\
-    '(if not exist %OUT% mkdir %OUT%) && '\
-    'for %%G in (%SRCS%) do ('\
-      'set target_dir=%%G&& '\
-      'for %%H in (!target_dir!) do ('\
-        'set platform_moniker=%%~nxH&& '\
-        'if \"!platform_moniker!\"==\"netstandard2.0\" ('\
-          '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && '\
-          'copy !target_dir!\\WebDriver.dll %OUT%\\!platform_moniker! &&'\
-          'copy !target_dir!\\WebDriver.xml %OUT%\\!platform_moniker!'\
-        ') else ('\
-          'set merge_args=/v4 /xmldocs /internalize /lib=%%H /out=%OUT%\\!platform_moniker!\\WebDriver.dll !target_dir!\\WebDriver.dll !target_dir!\\Newtonsoft.Json.dll&& '\
-          '(if \"!platform_moniker!\"==\"net35\" set merge_args=/v2 /xmldocs /internalize /lib=%%H /out=%OUT%\\!platform_moniker!\\WebDriver.dll !target_dir!\\WebDriver.dll !target_dir!\\Newtonsoft.Json.dll)&& '\
-          '$(exe //third_party/dotnet/ilrepack:ilrepack) !merge_args!'\
-        ')'\
-      ')'\
+    'setlocal EnableDelayedExpansion && ' +
+    '(if not exist %OUT% mkdir %OUT%) && ' +
+    'for %%G in (%SRCS%) do (' +
+      'set target_dir=%%G&& ' +
+      'for %%H in (!target_dir!) do (' +
+        'set platform_moniker=%%~nxH&& ' +
+        'if \"!platform_moniker!\"==\"netstandard2.0\" (' +
+          '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && ' +
+          'copy !target_dir!\\WebDriver.dll %OUT%\\!platform_moniker! &&' +
+          'copy !target_dir!\\WebDriver.xml %OUT%\\!platform_moniker!' +
+        ') else (' +
+          'set merge_args=/v4 /xmldocs /internalize /lib=%%H /out=%OUT%\\!platform_moniker!\\WebDriver.dll !target_dir!\\WebDriver.dll !target_dir!\\Newtonsoft.Json.dll&& ' +
+          '(if \"!platform_moniker!\"==\"net35\" set merge_args=/v2 /xmldocs /internalize /lib=%%H /out=%OUT%\\!platform_moniker!\\WebDriver.dll !target_dir!\\WebDriver.dll !target_dir!\\Newtonsoft.Json.dll)&& ' +
+          '$(exe //third_party/dotnet/ilrepack:ilrepack) !merge_args!' +
+        ')' +
+      ')' +
     ')',
   out = 'lib'
 )
@@ -130,22 +131,22 @@ genrule(
     ':netstandard2.0_strongnamed'
   ],
   cmd_exe = 
-    'setlocal EnableDelayedExpansion && '\
-    '(if not exist %OUT% mkdir %OUT%) && '\
-    'for %%G in (%SRCS%) do ('\
-      'set target_dir=%%G&& '\
-      'for %%H in (!target_dir!) do ('\
-        'set platform_moniker=%%~nxH&& '\
-        'if \"!platform_moniker!\"==\"netstandard2.0\" ('\
-          '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && '\
-          'copy !target_dir!\\WebDriver.dll %OUT%\\!platform_moniker! &&'\
-          'copy !target_dir!\\WebDriver.xml %OUT%\\!platform_moniker!'\
-        ') else ('\
-          'set merge_args=/v4 /xmldocs /internalize /keyfile=$(location //dotnet:keyfile) /lib=%%H /out=%OUT%\\!platform_moniker!\\WebDriver.dll !target_dir!\\WebDriver.dll !target_dir!\\Newtonsoft.Json.dll&& '\
-          '(if \"!platform_moniker!\"==\"net35\" set merge_args=/v2 /xmldocs /internalize /keyfile=$(location //dotnet:keyfile) /lib=%%H /out=%OUT%\\!platform_moniker!\\WebDriver.dll !target_dir!\\WebDriver.dll !target_dir!\\Newtonsoft.Json.dll)&& '\
-          '$(exe //third_party/dotnet/ilrepack:ilrepack) !merge_args!'\
-        ')'\
-      ')'\
+    'setlocal EnableDelayedExpansion && ' +
+    '(if not exist %OUT% mkdir %OUT%) && ' +
+    'for %%G in (%SRCS%) do (' +
+      'set target_dir=%%G&& ' +
+      'for %%H in (!target_dir!) do (' +
+        'set platform_moniker=%%~nxH&& ' +
+        'if \"!platform_moniker!\"==\"netstandard2.0\" (' +
+          '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && ' +
+          'copy !target_dir!\\WebDriver.dll %OUT%\\!platform_moniker! &&' +
+          'copy !target_dir!\\WebDriver.xml %OUT%\\!platform_moniker!' +
+        ') else (' +
+          'set merge_args=/v4 /xmldocs /internalize /keyfile=$(location //dotnet:keyfile) /lib=%%H /out=%OUT%\\!platform_moniker!\\WebDriver.dll !target_dir!\\WebDriver.dll !target_dir!\\Newtonsoft.Json.dll&& ' +
+          '(if \"!platform_moniker!\"==\"net35\" set merge_args=/v2 /xmldocs /internalize /keyfile=$(location //dotnet:keyfile) /lib=%%H /out=%OUT%\\!platform_moniker!\\WebDriver.dll !target_dir!\\WebDriver.dll !target_dir!\\Newtonsoft.Json.dll)&& ' +
+          '$(exe //third_party/dotnet/ilrepack:ilrepack) !merge_args!' +
+        ')' +
+      ')' +
     ')',
   out = 'lib'
 )

dotnet/src/webdriverbackedselenium/BUCK

@@ -1,4 +1,5 @@
-include_defs('//dotnet/SELENIUM_DOTNET_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//dotnet:selenium-dotnet-version.bzl", "SE_VERSION", "ASSEMBLY_VERSION")
 
 genrule(
   name = 'net35',
@@ -41,16 +42,16 @@ genrule(
     ':netstandard2.0'
   ],
   cmd_exe = 
-    'setlocal EnableDelayedExpansion && '\
-    '(if not exist %OUT% mkdir %OUT%) && '\
-    'for %%G in (%SRCS%) do ('\
-      'set target_dir=%%G&& '\
-      'for %%H in (!target_dir!) do ('\
-        'set platform_moniker=%%~nxH&& '\
-        '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && '\
-        'copy !target_dir!\\Selenium.WebDriverBackedSelenium.dll %OUT%\\!platform_moniker! &&'\
-        'copy !target_dir!\\Selenium.WebDriverBackedSelenium.xml %OUT%\\!platform_moniker!'\
-      ')'\
+    'setlocal EnableDelayedExpansion && ' +
+    '(if not exist %OUT% mkdir %OUT%) && ' +
+    'for %%G in (%SRCS%) do (' +
+      'set target_dir=%%G&& ' +
+      'for %%H in (!target_dir!) do (' +
+        'set platform_moniker=%%~nxH&& ' +
+        '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && ' +
+        'copy !target_dir!\\Selenium.WebDriverBackedSelenium.dll %OUT%\\!platform_moniker! &&' +
+        'copy !target_dir!\\Selenium.WebDriverBackedSelenium.xml %OUT%\\!platform_moniker!' +
+      ')' +
     ')',
   out = 'lib'
 )
@@ -100,16 +101,16 @@ genrule(
     ':netstandard2.0_strongnamed'
   ],
   cmd_exe = 
-    'setlocal EnableDelayedExpansion && '\
-    '(if not exist %OUT% mkdir %OUT%) && '\
-    'for %%G in (%SRCS%) do ('\
-      'set target_dir=%%G&& '\
-      'for %%H in (!target_dir!) do ('\
-        'set platform_moniker=%%~nxH&& '\
-        '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && '\
-        'copy !target_dir!\\Selenium.WebDriverBackedSelenium.dll %OUT%\\!platform_moniker! &&'\
-        'copy !target_dir!\\Selenium.WebDriverBackedSelenium.xml %OUT%\\!platform_moniker!'\
-      ')'\
+    'setlocal EnableDelayedExpansion && ' +
+    '(if not exist %OUT% mkdir %OUT%) && ' +
+    'for %%G in (%SRCS%) do (' +
+      'set target_dir=%%G&& ' +
+      'for %%H in (!target_dir!) do (' +
+        'set platform_moniker=%%~nxH&& ' +
+        '(if not exist %OUT%\\!platform_moniker! mkdir %OUT%\\!platform_moniker!) && ' +
+        'copy !target_dir!\\Selenium.WebDriverBackedSelenium.dll %OUT%\\!platform_moniker! &&' +
+        'copy !target_dir!\\Selenium.WebDriverBackedSelenium.xml %OUT%\\!platform_moniker!' +
+      ')' +
     ')',
   out = 'lib'
 )

java/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 export_file(
   name = 'changelog',
   out = "CHANGELOG",

java/client/src/com/thoughtworks/selenium/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(name = 'api',
   srcs = [

java/client/src/com/thoughtworks/selenium/condition/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 
 java_library(name = 'condition',
   srcs = glob(['*.java']),

java/client/src/com/thoughtworks/selenium/webdriven/BUCK

@@ -1,4 +1,3 @@
-
 java_library(name = 'webdriven',
   srcs = [
     'CompoundMutator.java',

java/client/src/com/thoughtworks/selenium/webdriven/commands/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 
 java_library(name = 'commands',
   srcs = glob(['*.java']),

java/client/src/org/openqa/selenium/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 build_stamp(name = 'build-stamp',
   kind = 'manifest',

java/client/src/org/openqa/selenium/chrome/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(
   name = 'chrome',

java/client/src/org/openqa/selenium/edge/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(
   name = 'edge',

java/client/src/org/openqa/selenium/firefox/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(name = 'firefox',
   maven_coords = 'org.seleniumhq.selenium:selenium-firefox-driver:jar:' + SE_VERSION,
@@ -39,4 +40,4 @@ export_file(
   name = 'amd64',
   src = '//cpp/prebuilt:noblur64',
   out = 'amd64/x_ignore_nofocus.so'
-)
+)

java/client/src/org/openqa/selenium/ie/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(name = 'ie',
   maven_coords = 'org.seleniumhq.selenium:selenium-ie-driver:' + SE_VERSION,

java/client/src/org/openqa/selenium/interactions/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 java_library(name = 'interactions',
   srcs = [
     'Actions.java',

java/client/src/org/openqa/selenium/io/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 java_library(
   name = 'io',
   srcs = glob(['*.java']),

java/client/src/org/openqa/selenium/lift/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(name = 'lift',
   srcs = glob(['**/*.java']),

java/client/src/org/openqa/selenium/logging/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 API_SRCS = [
   'Logs.java',
   'LogEntries.java',

java/client/src/org/openqa/selenium/net/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 java_library(
   name = 'net',
   srcs = glob(['*.java']),

java/client/src/org/openqa/selenium/opera/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(
   name = 'opera',

java/client/src/org/openqa/selenium/os/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 java_library(
   name = 'os',
   srcs = glob(['*.java']),

java/client/src/org/openqa/selenium/remote/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(
   name = 'api',

java/client/src/org/openqa/selenium/safari/BUCK

@@ -1,4 +1,5 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(name = 'safari',
   maven_coords = 'org.seleniumhq.selenium:selenium-safari-driver:' + SE_VERSION,

java/client/src/org/openqa/selenium/security/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 java_library(name = 'security',
   srcs = glob(['*.java']),
   deps = [

java/client/src/org/openqa/selenium/support/BUCK

@@ -1,4 +1,6 @@
-include_defs('//SELENIUM_VERSION')
+# BUILD FILE SYNTAX: SKYLARK
+# BUILD FILE SYNTAX: SKYLARK
+load("//:selenium-version.bzl", "SE_VERSION")
 
 java_library(name = 'support',
   srcs = [

java/client/src/org/openqa/selenium/support/events/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 java_library(name = 'events',
   srcs = glob(['**/*.java']),
   deps = [

java/client/src/org/openqa/selenium/support/ui/BUCK

@@ -1,3 +1,4 @@
+# BUILD FILE SYNTAX: SKYLARK
 java_library(name = 'clock',
   srcs = [
     'Clock.java',