[rb] deprecate passing in port to Remote Bridge

SeleniumHQ · Feb 24, 2017 · 58d2253 · 58d2253
1 parent d00e91f
commit 58d2253
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/rb/lib/selenium/webdriver/remote/bridge.rb b/rb/lib/selenium/webdriver/remote/bridge.rb
@@ -39,7 +39,13 @@ class Bridge
         def initialize(opts = {})
           opts = opts.dup
 
+          if opts.key?(:port)
+            warn <<-DEPRECATE.gsub(/\n +| {2,}/, ' ').freeze
+            [DEPRECATION] `:port` is deprecated. Use `:url` with full path
+            DEPRECATE
+          end
           port = opts.delete(:port) || 4444
+
           http_client = opts.delete(:http_client) { Http::Default.new }
           desired_capabilities = opts.delete(:desired_capabilities) { Capabilities.firefox }
           url = opts.delete(:url) { "http://#{Platform.localhost}:#{port}/wd/hub" }

diff --git a/rb/lib/selenium/webdriver/remote/w3c_bridge.rb b/rb/lib/selenium/webdriver/remote/w3c_bridge.rb
@@ -48,7 +48,13 @@ def initialize(opts = {})
 
           opts = opts.dup
 
+          if opts.key?(:port)
+            warn <<-DEPRECATE.gsub(/\n +| {2,}/, ' ').freeze
+            [DEPRECATION] `:port` is deprecated. Use full url desired.
+            DEPRECATE
+          end
           port = opts.delete(:port) || 4444
+
           http_client = opts.delete(:http_client) { Http::Default.new }
           desired_capabilities = opts.delete(:desired_capabilities) { W3CCapabilities.firefox }
           url = opts.delete(:url) { "http://#{Platform.localhost}:#{port}/wd/hub" }