Skip to content

Commit

Permalink
Deflake a test.
Browse files Browse the repository at this point in the history
I don't think, by contract, page MUST be loaded after
driver.executeScript("window.open(url, 'newWindow')");
driver.switchTo().window("newWindow");
returns. This has been flaky with Chrome on Windows XP, specifically.
  • Loading branch information
sevaseva committed Sep 12, 2014
1 parent e45d92f commit 6a34eac
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions java/client/test/org/openqa/selenium/PageLoadingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ public void testShouldDoNothingIfThereIsNothingToGoBackTo() {
"window.open('" + pages.formPage + "', 'newWindow')");
wait.until(newWindowIsOpened(currentWindowHandles));
driver.switchTo().window("newWindow");
wait.until(titleIs("We Leave From Here"));
String originalTitle = driver.getTitle();
driver.get(pages.blankPage);
wait.until(not(titleIs(originalTitle)));
Expand Down

0 comments on commit 6a34eac

Please sign in to comment.