[grid] synchronize read from field written by other thread

SeleniumHQ · Mar 29, 2024 · 6cda692 · 6cda692
1 parent 3ef121c
commit 6cda692
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/java/src/org/openqa/selenium/grid/sessionqueue/local/LocalNewSessionQueue.java b/java/src/org/openqa/selenium/grid/sessionqueue/local/LocalNewSessionQueue.java
@@ -216,7 +216,7 @@ public HttpResponse addToQueue(SessionRequest request) {
         boolean sessionCreated = data.latch.await(requestTimeout.toMillis(), MILLISECONDS);
 
         if (sessionCreated) {
-          result = data.result;
+          result = data.getResult();
         } else {
           result = Either.left(new SessionNotCreatedException("New session request timed out"));
         }
@@ -465,14 +465,18 @@ private class Data {
 
     public final Instant endTime;
     private final CountDownLatch latch = new CountDownLatch(1);
-    public Either<SessionNotCreatedException, CreateSessionResponse> result;
+    private Either<SessionNotCreatedException, CreateSessionResponse> result;
     private boolean complete;
 
     public Data(Instant enqueued) {
       this.endTime = enqueued.plus(requestTimeout);
       this.result = Either.left(new SessionNotCreatedException("Session not created"));
     }
 
+    public synchronized Either<SessionNotCreatedException, CreateSessionResponse> getResult() {
+      return result;
+    }
+
     public synchronized void setResult(
         Either<SessionNotCreatedException, CreateSessionResponse> result) {
       if (complete) {