Skip to content

Commit

Permalink
Two of the failing specs are now marked as fixed by Chromium and unco…
Browse files Browse the repository at this point in the history
…upling the expected errors now makes tests green!

Signed-off-by: Alex Rodionov <p0deje@gmail.com>
  • Loading branch information
luke-hill authored and p0deje committed Jan 22, 2018
1 parent 448e3ff commit 81e023a
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions rb/spec/integration/selenium/webdriver/storage_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,20 @@ module Selenium
module WebDriver
module DriverExtensions
describe HasWebStorage, only: {browser: %i[chrome firefox]} do
shared_examples_for 'web storage' do
shared_examples 'web storage' do
before do
driver.navigate.to url_for('clicks.html')
storage.clear
end

# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2177
it 'can get and set items', except: {browser: :chrome} do
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2177 - To monitor as recently fixed
it 'can get and set items' do
expect(storage).to be_empty
storage['foo'] = 'bar'
expect(storage['foo']).to eq('bar')

expect(storage['foo']).to eq('bar')
storage['foo1'] = 'bar1'

expect(storage['foo1']).to eq('bar1')

expect(storage.size).to eq(2)
Expand All @@ -48,8 +49,8 @@ module DriverExtensions
expect(storage.keys).to include('foo1', 'foo2', 'foo3')
end

# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2177
it 'can clear all items', except: {browser: :chrome} do
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2177 - To monitor as recently fixed
it 'can clear all items' do
storage['foo1'] = 'bar1'
storage['foo2'] = 'bar2'
storage['foo3'] = 'bar3'
Expand Down

0 comments on commit 81e023a

Please sign in to comment.