Skip to content

Commit

Permalink
Removing support for timeline perf logging preference in .NET ChromeD…
Browse files Browse the repository at this point in the history
…river

According to chromedriver bug #2034
(https://bugs.chromium.org/p/chromedriver/issues/detail?id=2034),
the enableTimeline performance logging preference is no longer accespted
by chromedriver.exe. The .NET language bindings will no longer send that
preference to the driver executable. Additionally, the peroperty setting
the preference has been deprecated, and will generate a compile-time
warning. The property will be remvoed in a future release. Fixes
issue #5481.
  • Loading branch information
jimevans committed Feb 11, 2018
1 parent 2e44b23 commit b1a7d4d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion dotnet/src/webdriver/Chrome/ChromeOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,6 @@ private Dictionary<string, object> GeneratePerformanceLoggingPreferencesDictiona
Dictionary<string, object> perfLoggingPrefsDictionary = new Dictionary<string, object>();
perfLoggingPrefsDictionary["enableNetwork"] = this.perfLoggingPreferences.IsCollectingNetworkEvents;
perfLoggingPrefsDictionary["enablePage"] = this.perfLoggingPreferences.IsCollectingPageEvents;
perfLoggingPrefsDictionary["enableTimeline"] = this.perfLoggingPreferences.IsCollectingTimelineEvents;

string tracingCategories = this.perfLoggingPreferences.TracingCategories;
if (!string.IsNullOrEmpty(tracingCategories))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// <copyright file="ChromePerformanceLoggingPreferences.cs" company="WebDriver Committers">
// <copyright file="ChromePerformanceLoggingPreferences.cs" company="WebDriver Committers">
// Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
Expand Down Expand Up @@ -58,6 +58,7 @@ public bool IsCollectingPageEvents
/// Defaults to <see langword="true"/>, but is set to <see langword="false"/> when tracing
/// is enabled by adding one or more tracing categories.
/// </summary>
[Obsolete("Setting 'enableTimeline is no longer supported by chromedriver. This preference will no longer be sent to chromedriver. This property will be removed in a future release.")]
public bool IsCollectingTimelineEvents
{
get { return this.isCollectingTimelineEvents; }
Expand Down

0 comments on commit b1a7d4d

Please sign in to comment.