Update GeckoDriver --port argument in all bindings. Fixes #2544

GeckoDriver updated the arguments to match that of IEDriver and ChromeDriver and now uses --port instead of --webdriver-port
SeleniumHQ · Aug 1, 2016 · c769178 · c769178
1 parent 5cbc386
commit c769178
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/dotnet/src/webdriver/Firefox/FirefoxDriverService.cs b/dotnet/src/webdriver/Firefox/FirefoxDriverService.cs
@@ -154,7 +154,7 @@ protected override string CommandLineArguments
 
                 if (this.Port > 0)
                 {
-                    argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --webdriver-port {0}", this.Port);
+                    argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --port {0}", this.Port);
                 }
 
                 if (!string.IsNullOrEmpty(this.browserBinaryPath))

diff --git a/java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java b/java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java
@@ -97,7 +97,7 @@ protected File findDefaultExecutable() {
     @Override
     protected ImmutableList<String> createArgs() {
       ImmutableList.Builder<String> argsBuilder = ImmutableList.builder();
-      argsBuilder.add(String.format("--webdriver-port=%d", getPort()));
+      argsBuilder.add(String.format("--port=%d", getPort()));
       if (getLogFile() != null) {
         argsBuilder.add(String.format("--log-file=\"%s\"", getLogFile().getAbsolutePath()));
       }

diff --git a/javascript/node/selenium-webdriver/firefox/index.js b/javascript/node/selenium-webdriver/firefox/index.js
@@ -321,8 +321,8 @@ function createGeckoDriverService(binary) {
     loopback: true,
     port: port,
     args: Promise.all([exe, port, marionettePort]).then(args => {
-      return ['-b', args[0], 
-              '--webdriver-port', args[1],
+      return ['-b', args[0],
+              '--port', args[1],
               '--marionette-port', args[2]];
     })
     // ,stdio: 'inherit'

diff --git a/py/selenium/webdriver/firefox/service.py b/py/selenium/webdriver/firefox/service.py
@@ -50,8 +50,8 @@ def __init__(self, executable_path, firefox_binary=None, port=0,
 
     def command_line_args(self):
         if self.firefox_binary:
-            return ["-b", self.firefox_binary, "--webdriver-port", "%d" % self.port]
-        return ["--webdriver-port", "%d" % self.port]
+            return ["-b", self.firefox_binary, "--port", "%d" % self.port]
+        return ["--port", "%d" % self.port]
 
     def send_remote_shutdown_command(self):
         pass
diff --git a/rb/lib/selenium/webdriver/firefox/service.rb b/rb/lib/selenium/webdriver/firefox/service.rb
@@ -30,7 +30,7 @@ class Service < WebDriver::Service
         private
 
         def start_process
-          server_command = [@executable_path, "--binary=#{Firefox::Binary.path}", "--webdriver-port=#{@port}", *@extra_args]
+          server_command = [@executable_path, "--binary=#{Firefox::Binary.path}", "--port=#{@port}", *@extra_args]
           @process       = ChildProcess.build(*server_command)
 
           if $DEBUG