Skip to content

Commit

Permalink
Make aliases actually be aliases, removing the need to flag them as s…
Browse files Browse the repository at this point in the history
…uch.

A small and extremely pedantic change that removes the need to flag
'aliases' as duplicates of other, already listed keys.

Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>
  • Loading branch information
colons authored and lukeis committed Mar 6, 2014
1 parent bab55bd commit ce1eb4d
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions py/selenium/webdriver/common/keys.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,17 @@ class Keys(object):
CANCEL = '\ue001' # ^break
HELP = '\ue002'
BACKSPACE = '\ue003'
BACK_SPACE = '\ue003' # alias
BACK_SPACE = BACKSPACE
TAB = '\ue004'
CLEAR = '\ue005'
RETURN = '\ue006'
ENTER = '\ue007'
SHIFT = '\ue008'
LEFT_SHIFT = '\ue008' # alias
LEFT_SHIFT = SHIFT
CONTROL = '\ue009'
LEFT_CONTROL = '\ue009' # alias
LEFT_CONTROL = CONTROL
ALT = '\ue00a'
LEFT_ALT = '\ue00a' # alias
LEFT_ALT = LEFT_ALT

This comment has been minimized.

Copy link
@barancev

barancev Mar 7, 2014

Member

Should it be
LEFT_ALT = ALT

This comment has been minimized.

Copy link
@andreastt

andreastt Mar 7, 2014

Member

@colons, can you fix?

This comment has been minimized.

Copy link
@shs96c

shs96c Mar 7, 2014

Member

Alt and left alt are different keys.

This comment has been minimized.

Copy link
@colons

colons Mar 7, 2014

Author Contributor

Oh, man, I thought I was being super paranoid about that, but I also thought pyflakes would have caught it. Fixed in #182. If there are different keycodes for left alt and alt and these were set up as aliases in error, we should probably fix that as well, since we're here.

This comment has been minimized.

PAUSE = '\ue00b'
ESCAPE = '\ue00c'
SPACE = '\ue00d'
Expand All @@ -47,19 +47,19 @@ class Keys(object):
END = '\ue010'
HOME = '\ue011'
LEFT = '\ue012'
ARROW_LEFT = '\ue012' # alias
ARROW_LEFT = LEFT
UP = '\ue013'
ARROW_UP = '\ue013' # alias
ARROW_UP = UP
RIGHT = '\ue014'
ARROW_RIGHT = '\ue014' # alias
ARROW_RIGHT = RIGHT
DOWN = '\ue015'
ARROW_DOWN = '\ue015' # alias
ARROW_DOWN = DOWN
INSERT = '\ue016'
DELETE = '\ue017'
SEMICOLON = '\ue018'
EQUALS = '\ue019'

NUMPAD0 = '\ue01a' # numbe pad keys
NUMPAD0 = '\ue01a' # number pad keys
NUMPAD1 = '\ue01b'
NUMPAD2 = '\ue01c'
NUMPAD3 = '\ue01d'
Expand Down

0 comments on commit ce1eb4d

Please sign in to comment.