Skip to content

Commit

Permalink
Ignore-Behaviour ignored for HtmlUnit in Test
Browse files Browse the repository at this point in the history
With regards to SeleniumHQ/htmlunit-driver#57 HtmlUnit doesn't throw UnhandledAlertException in case of Ignore. Basically an exception is totally useless at this point

Signed-off-by: Alexei Barantsev <barancev@gmail.com>
  • Loading branch information
Marc Schlegel authored and barancev committed Jan 8, 2018
1 parent 734f2b9 commit d93e06b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions java/client/test/org/openqa/selenium/AlertsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,7 @@ public void testShouldHandleAlertOnWindowClose() {

@Test
@Ignore(CHROME)
@Ignore(value = HTMLUNIT, reason = "https://github.com/SeleniumHQ/htmlunit-driver/issues/57")
@NotYetImplemented(value = MARIONETTE,
reason = "https://bugzilla.mozilla.org/show_bug.cgi?id=1279211")
public void testIncludesAlertTextInUnhandledAlertException() {
Expand Down

2 comments on commit d93e06b

@rbri
Copy link
Contributor

@rbri rbri commented on d93e06b Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this is fixed now in htmlunit driver and you can enable this test for HtmlUnit again

@barancev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll unignore it as soon as we include the updated version of HtmlUnitDriver.

Please sign in to comment.