Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Router #7

Closed
selfup opened this issue Jul 24, 2016 · 2 comments
Closed

React Router #7

selfup opened this issue Jul 24, 2016 · 2 comments
Labels
architecture bug

Comments

@selfup
Copy link
Owner

selfup commented Jul 24, 2016 •
edited
Loading

Works with a server but not with a Static page.

Being talked about here: facebook/create-react-app#84
@selfup
Copy link
Owner Author

selfup commented Jul 24, 2016

If browser history is removed from the router config, the website will work on with a server as well as on gh-pages.

However this produces a non production friendly URL.

@selfup
Copy link
Owner Author

selfup commented Jul 26, 2016

Decided to stick with hash history and be ok with weird url structure for gh-pages. Switch to browser history on a VPS for production will be super simple.

@selfup selfup closed this as completed Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@selfup