x264 encoder failing to initialize

[PMohanJ]

The default software encoder x264 is failing to initialize while trying to access the desktop from browsers like brave and edge, saying the height not divisible by 2.

Here are some logs:

Brave browser's resolution: 1920x937

Edge browser's resolution: 1860x927

But in chrome it's working fine as the pixels of height is even numbered: 1920x912

Client device details:

• windows 11
• Brave Version 1.61.104 Chromium: 120.0.6099.115 (Official Build) (64-bit)]
• Microsoft Edge Version 120.0.2210.77 (Official build) (64-bit)
• Chrome Version 120.0.6099.110 (Official Build) (64-bit)

Image used is: ghcr.io/selkies-project/selkies-gstreamer/gst-py-example:main-ubuntu20.04

[ehfd]

Yeah, that is a known restriction in x264... The solution for now is to use an even viewport... I'll think of a solution.

[PMohanJ]

Hi @ehfd,

After looking into web-interface code part, I came across below logic where the height is being calculated.

parseInt((document.body.offsetHeight - document.body.offsetHeight%2) * window.devicePixelRatio)

It seems like the point of subtracting the offsetHeight%2 from offsetHeight is just to eliminate the odd numbered pixel.
If that's the case, the reason for me still ending up with odd number is..
The DevicePixelRation of my device is 1.25
brave browser offsetHeight=750 => (750 - 0) * 1.25 = 937.5

So if we just do that subtraction after the multiplication then problem solved. I've tried this and I no longer face that not divisible by 2 error.

Let me know what you think, I've got the changes ready for PR.

[ehfd]

I totally remember that part of the code now... and your solution is right. PR it on!