-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Powerline #115
Comments
Hah – I just tried Powerline last week and thought, “yuck, Solarized needs to handle this better.” |
Here are some screenshots of Vim running on my Mac with the Solarized color scheme and "Inconsolata-dz for Powerline" font. It pains me to say it, but Vim has a nice look going. Perhaps we can come close to this in Emacs? I'm no pro with Elisp, but I'd be happy to help out where possible. Where in the codebase would this patch be applied? Normal ModeInsert ModeVisual Mode |
I've had good results with another mode-line customization package, smart-mode-line. It respects all of solarized faces with this setting: (setq sml/theme 'respectful) It even works toggling solarized light to dark. https://github.com/Bruce-Connor/smart-mode-line SML also looks more like emacs and less like vim, but the vim look is cool too. |
+1 to support for powerline :-) |
Ok, I found three bugs in Powerline’s handling of faces and I plan to submit a PR for it:
The first two seem pretty straightforward. I might just submit those first. I imagine the last one probably only affects Mac users, but I’m just guessing. |
I see milkypostman/powerline#22 is the same issue. I have a fix for the first two points that I should get submitted today. (As well as Solarized-friendly settings for the Powerline faces.) |
Point 3 is covered by milkypostman/powerline#54, so I’ll commit some Solarized Powerline faces and consider this closed (but I am happy to take suggestions of other combinations for the Powerline display – not particularly excited with what I came up with, but at least everything is readable). |
(But Powerline won’t look right yet unless you pull from git or wait for the next version to hit MELPA.) |
Please add support for one of Emacs' most popular ports of powerline.
https://github.com/milkypostman/powerline
The text was updated successfully, but these errors were encountered: