fix: fix load-parser-config #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be paired well with #512 |
|
appreciate the investigation and contribution on this @tkdaj we arent ready to accept this yet, though, since we will likely drop support for loading the previous major versions of the conventional-changelog presets in favor of the new format, as mentioned in semantic-release/semantic-release#2929. the downside of the decision to take the breaking approach is that we will need to release our change a bit more slowly to work the breaking changes through our dependency hierarchy and through our core package. we will likely at least reference this approach in our solution. |
|
No problem. Thank you for all your work on this package! |
|
superceded by #519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the current code does not work when the value of
loadedConfigis an async function.After updating our project to use version 7 of
conventional-changelog-conventionalcommits, semantic-release stopped working due to this bug because the preset results in an async function being assigned toloadedConfig. This patch allows for loadedConfig to also be an async function.