Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct docs branch for fail-comment links #893

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

Dun-sin
Copy link
Contributor

@Dun-sin Dun-sin commented Aug 3, 2024

Fixes #3413

@babblebey babblebey changed the title chore: add correct faq link chore(docs): add correct faq link Aug 3, 2024
Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking steps to get this updated. a few small tweaks are needed, but this should be ready to merge with those updates

lib/get-fail-comment.js Outdated Show resolved Hide resolved
lib/get-fail-comment.js Outdated Show resolved Hide resolved
@travi travi changed the title chore(docs): add correct faq link fix(docs): add correct faq link Aug 9, 2024
@travi travi changed the title fix(docs): add correct faq link fix(docs): correct docs branch for fail-comment links Aug 9, 2024
Co-authored-by: Matt Travi <126441+travi@users.noreply.github.com>
lib/get-fail-comment.js Outdated Show resolved Hide resolved
Copy link
Member

@babblebey babblebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@Dun-sin
Copy link
Contributor Author

Dun-sin commented Aug 9, 2024

Thanks for the correction @travi @babblebey 💪🏽

Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for the contribution!

@travi travi merged commit b591730 into semantic-release:master Aug 9, 2024
6 checks passed
Copy link

github-actions bot commented Aug 9, 2024

🎉 This issue has been resolved in version 10.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The FAQ url provided is wrong
3 participants