fix(success): PRs not recognized as resolved issues #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l fields for `PullRequest`
…`type` parameter and include `__typename` in queries to use in its place
…quest` for improved query flexibility
…ccess tests for improved type handling
… in integration tests
travi
approved these changes
Nov 1, 2024
|
🎉 This PR is included in version 11.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request address the case where a PR resolved in the body of an associatedPR of a commit is neither recognized as an Issue nor a PR.
Changes Made
buildRelatedIssuesQuery's GraphQL query which fetches details for related resolved Issues found in PR body/commit message to fetch for PRs too in cases where a PR is found resolved in the PR body/commit messages. This introduced the usage of the"repository".issueOrPullRequestobject replacing the initial"repository".issue.__typenamefield to response object of all graphql request for issues and prs in the success lifecycle which was inturn used as stated in next change...typeparamater in thebuildIssuesOrPRsFromResponseNodeutil, leaving its function to being performed by the newly introduced__typenameproperty per nodeRelated Issue
Fixes #942