Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify definition of CoherentProductUnit and CoherentRatioUnit #587

Open
sa-bpelakh opened this issue Sep 29, 2021 · 1 comment
Open
Labels
effort: small Requires less than one day to complete impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) status: deferred Deferred to a later release for reasons other than it is a major change topic: units and measures

Comments

@sa-bpelakh
Copy link
Collaborator

Can CoherentProductUnit, currently defined as

    EquivalentTo: 
        gist:ProductUnit
         and (gist:hasMultiplicand only 
            ((gist:BaseUnit or gist:CoherentProductUnit or gist:CoherentRatioUnit)))
         and (gist:hasMultiplier only 
            ((gist:BaseUnit or gist:CoherentProductUnit or gist:CoherentRatioUnit)))

cannot be simplified to

    EquivalentTo: 
        gist:ProductUnit
         and (gist:hasMultiplicand only gist:CoherentUnit)
         and (gist:hasMultiplier only gist:CoherentUnit)

since the definition of CoherentUnit is exactly (gist:BaseUnit or gist:CoherentProductUnit or gist:CoherentRatioUnit).

Similarly with CoherentRatioUnit.

@sa-bpelakh sa-bpelakh added impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) effort: small Requires less than one day to complete labels Sep 29, 2021
@uscholdm uscholdm added topic: units and measures status: deferred Deferred to a later release for reasons other than it is a major change labels Oct 23, 2023
@uscholdm
Copy link
Contributor

DEFERRED: until there is a revision to units and magnitudes in a future major release. #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: small Requires less than one day to complete impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) status: deferred Deferred to a later release for reasons other than it is a major change topic: units and measures
Projects
None yet
Development

No branches or pull requests

2 participants