Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten geo predicates #812

Closed
rjyounes opened this issue Mar 30, 2023 · 4 comments · Fixed by #1085
Closed

Shorten geo predicates #812

rjyounes opened this issue Mar 30, 2023 · 4 comments · Fixed by #1085
Assignees

Comments

@rjyounes
Copy link
Collaborator

Some of us think the shift to more explicit, but longer, predicates in gist 11 was overkill. The proposal is to go back to something like (without inverses, which are eliminated in #506):

  • geoContains
  • geoOccupies
  • geoOccupiesPermanently

However, the occupies predicates are considered for removal in issue #809.

@rjyounes
Copy link
Collaborator Author

I also noted that we use "geo" in the class names: GeoPoint, GeoRegion, etc., so it actually seems odd to use the full word for the properties.

@uscholdm
Copy link
Contributor

'geoContains' has been removed. We now use isGeographicallyContainedIn. So presumably, the proposal is to

  • rename isGeographicallyContainedIn to isGeoContainedIn

I think it is a reasonable proposal. One downside is the risk of our flip-flopping too much with name changes for tidiness reasons resulting in major releases. It could be a nuisance to our users.

@rjyounes
Copy link
Collaborator Author

Yes, that's the proposal. I realize the flip-flopping is unappealing, but we provide migration scripts with major versions to ease the burden of renaming.

@rjyounes rjyounes self-assigned this Aug 29, 2023
@rjyounes rjyounes moved this from To Do to In Progress in gist Version 13.0.0 Apr 18, 2024
@rjyounes rjyounes moved this from In Progress to To Do in gist Version 13.0.0 Apr 18, 2024
@rjyounes
Copy link
Collaborator Author

rjyounes commented Apr 18, 2024

Also remove the occupies predicates as per issue #809, now captured in #947 (comment).

@rjyounes rjyounes moved this from To Do to In Progress in gist Version 13.0.0 Apr 18, 2024
@rjyounes rjyounes moved this from In Progress to To Do in gist Version 13.0.0 Apr 18, 2024
@rjyounes rjyounes moved this from To Do to In Progress in gist Version 13.0.0 Apr 18, 2024
@rjyounes rjyounes moved this from In Progress to To Do in gist Version 13.0.0 Apr 18, 2024
@rjyounes rjyounes moved this from To Do to In Progress in gist Version 13.0.0 Apr 18, 2024
@rjyounes rjyounes moved this from In Progress to In Review in gist Version 13.0.0 Apr 18, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in gist Version 13.0.0 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants