Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default prefix #898

Open
Jamie-SA opened this issue Jun 26, 2023 · 8 comments
Open

Remove default prefix #898

Jamie-SA opened this issue Jun 26, 2023 · 8 comments
Assignees

Comments

@Jamie-SA
Copy link
Contributor

I seem to remember seeing something that recommended that ontology files should not have default prefix statements (the blank or : namespace). I don't know why we'd want to use one in gist but I see one in gistCore. I suggest we remove it.

@rjyounes
Copy link
Collaborator

Agreed. @dylan-sa and I observed this somewhere and wondered if Protege was adding it. If so, we could include removing it in the pre-commit hook that deletes the skos annotation declarations.

@rjyounes
Copy link
Collaborator

rjyounes commented Nov 9, 2023

We would need a process that runs after the serializer to remove the base declaration. Could include in the serializer pre-commit.

DECISION: Include in the serializer pre-commit and the release process.

@rjyounes
Copy link
Collaborator

rjyounes commented Nov 9, 2023

@sa-bpelakh Please confirm that this is indeed inserted by the serializer before you begin this implementation. Possibly I'm misremembering.

@rjyounes
Copy link
Collaborator

rjyounes commented Nov 9, 2023

@uscholdm Do we want to ask the EDM Council to add this as an option to the serializer?

@uscholdm
Copy link
Contributor

uscholdm commented Nov 9, 2023

It worked before, so it might work again - especially since use of Protege is so widespread.

We'd need to have a clear example to hand them. A ton of experiments were done, that would have to be condensed, clear and concise.

@sa-bpelakh
Copy link
Collaborator

@sa-bpelakh Please confirm that this is indeed inserted by the serializer before you begin this implementation. Possibly I'm misremembering.

I checked, and the serializer does not re-add the default namespace if it is removed manually. If I modify the commit hook to remove it anyhow, and then push in a single commit removing it from every ontology, we won't even need to have it as a step in the build - unless you think someone out there is bypassing the commit hook.

@uscholdm
Copy link
Contributor

unless you think someone out there is bypassing the commit hook.

That could happen if a setup is not done correctly or gets corrupted.

@rjyounes rjyounes moved this to To do (typically assigned) in gist Version 12.1.0 Nov 19, 2023
@rjyounes rjyounes moved this from In Triage to In Progress in gist Version 12.2.0 Feb 8, 2024
@rjyounes rjyounes moved this from In Progress to To Do in gist Version 12.2.0 Feb 8, 2024
@kchastain703 kchastain703 moved this from In Triage to To Do in gist Version 13.0.0 Feb 28, 2024
@rjyounes
Copy link
Collaborator

rjyounes commented May 23, 2024

DECISION: The pre-commit hook should remove the default prefix (similarly to how it removed stub SKOS definitions previously). There is a new issue, #1094, to remove it manually for the 13.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

No branches or pull requests

4 participants