Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust nightly build fails due to unsafe libc call #18

Closed
rkowalewski opened this issue Jan 19, 2021 · 8 comments
Closed

Rust nightly build fails due to unsafe libc call #18

rkowalewski opened this issue Jan 19, 2021 · 8 comments

Comments

@rkowalewski
Copy link

rkowalewski commented Jan 19, 2021

Hello,

you recent fixed an issue due to an unsafe libc call in rust-lang/libc#2035.

Can you tell me how to use the libc master branch in the Rust nightly build? The current bootstrap config seems to use tag 0.2.79.
I am kind of new to Rust, so I am not very familiar with its toolchain.

@semarie
Copy link
Owner

semarie commented Jan 19, 2021

it isn't possible simply.

the PR is only a first step. the full correction needs a libc release (asked in rust-lang/libc#2038) and update rust repository to use the newer libc version.

@rkowalewski
Copy link
Author

Thank you for the quick response. Then I just need to wait.

@semarie
Copy link
Owner

semarie commented Jan 28, 2021

Now that a libc version has been released with the fix, I made PR rust-lang/rust#81464 for use it in rustc.

@rkowalewski
Copy link
Author

Thank you for taking care on this.

@rkowalewski rkowalewski reopened this Feb 7, 2021
@rkowalewski
Copy link
Author

While the original issue described here is resolved, there is a follow-up one.

I submitted it to rust-lang/rust#81787. Is this issue specific to the way how we build rust on OpenBSD? Or is it possible to skip some tools like rustfmt when building rustc? If this issue is not specific to our toolchain on OpenBSD, please just close the issue here.

See my attached build.log

@semarie
Copy link
Owner

semarie commented Feb 7, 2021

it is, currently, an expected failure. See the rust-toolstate page: it mentions rustfmt and rls are currently failing in official builds.

to customize the build, see the config.toml file inside the build directory, specially the build.tools directive. You might need to patch build.sh to avoid it overrides your customization.

@semarie semarie closed this as completed Feb 7, 2021
@semarie
Copy link
Owner

semarie commented Feb 7, 2021

oh, and please to not reopen this issue if your problem isn't related to this issue. create a new issue for a new problem.

@rkowalewski
Copy link
Author

I initially thought about opening a new issue but first wanted to know if it is the right place here. Sorry for the circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants