-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed store/ARC2_StoreEndpoint.php: $this has no property named $store #142
Conversation
The old version was giving an error, because $this has no property named $store
Pull Request Test Coverage Report for Build 123
💛 - Coveralls |
Hi @ailintom, thank you. Can you please add a test to show that there was a problem before? |
Here: #143 |
Added test file `tests/unit/ARC2_StoreEndpointTest.php` for semsol#142 written by @ailintom Now we have a test (semsol#143) which shows a problem and a potential fix (semsol#142). Lets see if all tests run through. Co-authored-by: Alexander Ilin-Tomich <ilintomich@gmail.com>
Unfortunately 1 test still fails: https://travis-ci.org/github/semsol/arc2/jobs/665734128 Configuration: MariaDB 10.5 + PHP 7.4 + mysqli Travis run: https://travis-ci.org/github/semsol/arc2/builds/665734071 Any idea? |
MySQL fails to start; hence, PHPUnit doesn't even start also. The problem is with the configuration of MySQL. It has nothing to do with the Pull Request. |
I increased to sleep time from |
So that wget doesn't fail on Error 429 from Github
Now everything seems to be fine; the only failed travis job is due to HTTP Error 429 too many requests on GitHub. I have tried to patch .travis.yml with --retry-on-http-error=429 to consider this error as a non-fatal, transient error, but wget does not recognize this command-line option |
This reverts commit 5c07df0.
added travis_retry before wget to exclude error 429
Travis and coverage.io looking fine. Good job @ailintom |
The old version was giving an error, because $this has no property named $store