Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed store/ARC2_StoreEndpoint.php: $this has no property named $store #142

Merged
merged 6 commits into from
Mar 24, 2020
Merged

Fixed store/ARC2_StoreEndpoint.php: $this has no property named $store #142

merged 6 commits into from
Mar 24, 2020

Commits on Mar 20, 2020

  1. Fix a mistake in copypasted code 

    The old version was giving an error, because $this has no property named $store
    @ailintom
    ailintom authored Mar 20, 2020
    Configuration menu
    Copy the full SHA
    9ed8dd2 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Added tests/unit/ARC2_StoreEndpointTest.php from semsol#143 

    Added test file `tests/unit/ARC2_StoreEndpointTest.php` for semsol#142 written by @ailintom

Now we have a test (semsol#143) which shows a problem and a potential fix (semsol#142). 
Lets see if all tests run through.

Co-authored-by: Alexander Ilin-Tomich <ilintomich@gmail.com>
    @k00ni @ailintom
    k00ni and ailintom authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    7c16548 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:semsol/arc2 into patch-1

    @k00ni
    k00ni committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    3a3f59a View commit details
    Browse the repository at this point in the history

  3. retry-on-http-error=429 

    So that wget doesn't fail on Error 429 from Github
    @ailintom
    ailintom authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    5c07df0 View commit details
    Browse the repository at this point in the history

  4. Revert "retry-on-http-error=429" 

    This reverts commit 5c07df0.
    @ailintom
    ailintom committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    f46bc4b View commit details
    Browse the repository at this point in the history

  5. travis_retry before wget to exclude error 429 

    added  travis_retry before wget to exclude error 429
    @ailintom
    ailintom authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    7709770 View commit details
    Browse the repository at this point in the history