Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timer for propose block #217

Open
orogvany opened this issue Jul 9, 2019 · 1 comment
Open

Add timer for propose block #217

orogvany opened this issue Jul 9, 2019 · 1 comment
Labels
enhancement An enhancement to existing implementation

Comments

@orogvany
Copy link
Collaborator

orogvany commented Jul 9, 2019

Since we're moving to a gas driven block size
We should be aware of low-performing validators.

If we're proposing a block, and we get down to 4 or so seconds, we should just propose what we have, instead of adding more transactions (or problematic slow transactions) that eat up our time.

Rather propose a block with less gas than max than miss our proposal window.

@orogvany orogvany added the enhancement An enhancement to existing implementation label Jul 9, 2019
@orogvany
Copy link
Collaborator Author

This is probably unnecessary now that validators can specify their own gas limit, but this would help safeguard them all the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to existing implementation
Projects
None yet
Development

No branches or pull requests

1 participant